[haiku-commits] Re: haiku: hrev46694 - in src/add-ons: kernel/drivers/graphics/intel_extreme accelerants/intel_extreme

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 17 Jan 2014 13:39:43 -0500

On Fri, Jan 17, 2014 at 12:00 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> Am 17/01/2014 14:49, schrieb pulkomandy@xxxxxxxxxxxxx:
>
>> +static struct display_mode_hook {
>> +       bool active;
>> +       display_mode *dm;
>> +       struct {
>> +               uint16 width;
>> +               uint16 height;
>> +               uint16 space;
>> +       } mode;
>> +} display_mode_hook;
>
> Should be called sDisplayModeHook instead

I don't think that's true. I'm looking in the coding guidelines for
confirmation and I can't find anything about this. Judging from
examples in the source code C struct's follow the
all_lowercase_underscore_variable_name_convention.

src/add-ons/kernel/drivers/network/ar81xx/dev/ale/if_ale.c:L180
src/add-ons/kernel/drivers/graphics/intel_extreme/bios.cpp:L100
src/add-ons/kernel/debugger/hangman/hangman.c:L523

along with many many other examples (just grep for them).

Other related posts: