[haiku-commits] haiku: hrev46689 - src/system/libroot/posix/unistd src/system/libroot/os/arch/x86 headers/posix

  • From: pdziepak@xxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 16 Jan 2014 21:13:12 +0100 (CET)

hrev46689 adds 2 changesets to branch 'master'
old head: f1a28e35ec5149eedaa3c4b38922091d5f578d52
new head: dd8a866adc49745a4e8e0256da7335d397613d5c
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=dd8a866+%5Ef1a28e3

----------------------------------------------------------------------------

79c9b82: libroot: sync() should not return any value

dd8a866: libroot/x86: Fix indirect jump

                                    [ Pawel Dziepak <pdziepak@xxxxxxxxxxx> ]

----------------------------------------------------------------------------

3 files changed, 5 insertions(+), 10 deletions(-)
headers/posix/unistd.h                      |  2 +-
src/system/libroot/os/arch/x86/syscalls.inc |  2 +-
src/system/libroot/posix/unistd/sync.c      | 11 +++--------

############################################################################

Commit:      79c9b824e49b47871ce101e8f32e2f3a13a981e7
URL:         http://cgit.haiku-os.org/haiku/commit/?id=79c9b82
Author:      Pawel Dziepak <pdziepak@xxxxxxxxxxx>
Date:        Sun Dec 22 22:14:51 2013 UTC

libroot: sync() should not return any value

----------------------------------------------------------------------------

diff --git a/headers/posix/unistd.h b/headers/posix/unistd.h
index 4cc5e3f..dc5897e 100644
--- a/headers/posix/unistd.h
+++ b/headers/posix/unistd.h
@@ -189,7 +189,7 @@ extern ssize_t  write_pos(int fd, off_t pos, const void 
*buffer,size_t count);
 extern ssize_t pwrite(int fd, const void *buffer, size_t count, off_t pos);
 extern off_t   lseek(int fd, off_t offset, int whence);
 
-extern int             sync(void);
+extern void            sync(void);
 extern int             fsync(int fd);
 
 extern int             chown(const char *path, uid_t owner, gid_t group);
diff --git a/src/system/libroot/posix/unistd/sync.c 
b/src/system/libroot/posix/unistd/sync.c
index ed0acbb..3f56fe0 100644
--- a/src/system/libroot/posix/unistd/sync.c
+++ b/src/system/libroot/posix/unistd/sync.c
@@ -22,14 +22,9 @@ fsync(int fd)
 }
 
 
-int
+void
 sync(void)
 {
-       int status = _kern_sync();
-       if (status < 0) {
-               __set_errno(status);
-               status = -1;
-       }
-
-       return status;
+       _kern_sync();
 }
+

############################################################################

Revision:    hrev46689
Commit:      dd8a866adc49745a4e8e0256da7335d397613d5c
URL:         http://cgit.haiku-os.org/haiku/commit/?id=dd8a866
Author:      Pawel Dziepak <pdziepak@xxxxxxxxxxx>
Date:        Thu Jan 16 17:54:17 2014 UTC

libroot/x86: Fix indirect jump

----------------------------------------------------------------------------

diff --git a/src/system/libroot/os/arch/x86/syscalls.inc 
b/src/system/libroot/os/arch/x86/syscalls.inc
index 517d650..08eb670 100644
--- a/src/system/libroot/os/arch/x86/syscalls.inc
+++ b/src/system/libroot/os/arch/x86/syscalls.inc
@@ -23,7 +23,7 @@
                movl    $n, %eax;                                               
                        \
                movl    __gCommPageAddress, %edx;                               
        \
                addl    4 * COMMPAGE_ENTRY_X86_SYSCALL(%edx), %edx;     \
-               jmp     %edx;                                                   
                        \
+               jmp     *%edx;                                                  
                        \
        FUNCTION_END(name)
 
 #define SYSCALL0(name, n) _SYSCALL(name, n)


Other related posts:

  • » [haiku-commits] haiku: hrev46689 - src/system/libroot/posix/unistd src/system/libroot/os/arch/x86 headers/posix - pdziepak