[haiku-commits] Re: haiku: hrev46669 - in src: add-ons/kernel/partitioning_systems/intel add-ons/kernel/file_systems/udf add-ons/kernel/network/datalink_protocols/ipv6_datagram system/runtime_loader/arch/arm system/runtime_loader

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 13 Jan 2014 22:10:10 +0100

Am 13/01/2014 21:57, schrieb Adrien Destugues:
udf: Move constant to header.

This way, it is a compile time constant and Clang does no longer
complain about dynamic arrays of non-POD types.

Could anyone explain to me the difference? There should not be one.
Whether something is in a header or a source file is completely
irrelevant in C and C++ -- it's the same thing.
It was extern in the header before, defined in one .c file, but referenced
in another to size an array. As a result, the size of that array was only
known at link-time, making it dynamic.

Alright, I missed the extern, thanks for the explanation.
However, shouldn't it be static, too, to avoid double declaration?

Bye,
   Axel.


Other related posts: