[haiku-commits] Re: haiku: hrev46660 - build/jam src/system/libroot/posix/glibc/stdio-common

  • From: Jonathan Schleifer <js-haiku-commits@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 15 Jan 2014 16:46:18 +0100

Am 14.01.2014 um 19:06 schrieb Ingo Weinhold <ingo_weinhold@xxxxxx>:

> I wouldn't do a per compiler file just for the -Werror settings, but I guess 
> a file per compiler with various compiler specific setup, including the 
> -Werror settings, wouldn't harm.

Wouldn't this basically turn out to be what I did, specifying how -Werror 
should handled for the compiler in a central file?

Btw: Even adding an (optional) argument to EnableWerror would be a bad idea: 
You would add a 1 there if it should be also enabled for Clang. What if we add 
other compilers, like Path64? Then we either need to convert it to a mask (not 
very user friendly) or add another argument (and thus change all places again).

Adding if ! $(CLANG) {} in the components where it should not be added would 
still be less work then changing all places, I guess. And would be more clear 
and would not need to be removed / changed when we add another compiler in the 
future.

--
Jonathan

Other related posts: