On 01/14/2014 03:54 PM, Axel Dörfler wrote:
Am 14/01/2014 13:14, schrieb Jonathan Schleifer:So the patch should actually change all places where EnableWerror is called? Or is there something like default values for targets, so that I can disable it for Clang by default?
I just had a closer look and noticed that ATM it isn't easily possible to enable -Werror per architecture. I guess my elegant solution in  wasn't so future proof after all. I'll meditate on how best to solve this. We'll probably end up introducing another per architecture config variable, but some additional refactoring might be good as well.
Not sure how it works now, or if that's possible, but my preference would be a single file where those are defined (one file for each compiler).
I wouldn't do a per compiler file just for the -Werror settings, but I guess a file per compiler with various compiler specific setup, including the -Werror settings, wouldn't harm.
CU, Ingo http://cgit.haiku-os.org/haiku/commit/?id=724f4e2d387826f0b501981e542ea21ca99bd64d