[haiku-commits] Re: haiku: hrev46369 - src/apps/webpositive src/kits/network/libnetapi build/jam/repositories/HaikuPorts build/jam

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 15 Nov 2013 20:00:00 +0100

Hi,

Am 15.11.2013 um 18:53 schrieb pulkomandy@xxxxxxxxxxxxx:
> 
> Commit:      564e2566492c1b9cf9bf7fdaede7ea7683dab5dd
> URL:         http://cgit.haiku-os.org/haiku/commit/?id=564e256
> Author:      Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
> Date:        Fri Nov 15 15:32:18 2013 UTC
> 
> Various fixes to Services Kit
> 
> * Remove useless dummy protocol loop in UrlRequest
> * Stop HTTP requests before deleting the socket and other things the
> loop may still be using
> * Deletion of items from the authentication map wasn't working
> * Remove some debug traces
> 

[...]

> diff --git a/src/kits/network/libnetapi/UrlContext.cpp 
> b/src/kits/network/libnetapi/UrlContext.cpp
> index 429eb59..8e34e0a 100644
> --- a/src/kits/network/libnetapi/UrlContext.cpp
> +++ b/src/kits/network/libnetapi/UrlContext.cpp
> @@ -21,8 +21,7 @@ BUrlContext::BUrlContext()
>       fAuthenticationMap(NULL)
> {
>       fAuthenticationMap = new(std::nothrow) BHttpAuthenticationMap();
> -     if(!fAuthenticationMap)
> -             return;

Why remove a check for allocation success?

Best regards,
-Stephan



Other related posts: