[haiku-commits] Re: haiku: hrev46368 - in src: add-ons/screen_savers/flurry bin/screen_blanker kits/screensaver preferences/screensaver

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 15 Nov 2013 22:55:42 +0100

On 11/15/2013 05:31 AM, jscipione@xxxxxxxxx wrote:
d34a680: Screen Saver: fix race condition

I honestly don't see what race condition this fixes. The only change is that the window isn't locked from the screen saver runner thread.

Besides that, you introduced a new problem: while fWindow->Lock() is save, even if the window does no longer exist, fView->fWindow->Lock() is not.

Can you elaborate a bit more what this is supposed to fix, and what things it is supposed to improve? Locking a window for a short time surely isn't a problem, especially when it's only done once when the runner is started.

Bye,
   Axel.


Other related posts: