hrev46285 adds 2 changesets to branch 'master' old head: 080ef2e53ddbb7ead440b0ceb3e348a7303df9e4 new head: 2be66b5125f0ff7bf653463f391c9cafcf0d8185 overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=2be66b5+%5E080ef2e ---------------------------------------------------------------------------- c29f2d2: Close the menu on keypress. After _InvokeItem(), call QuitTracking() to close the menu. Incidentally this also seems to fix #9863. 2be66b5: Remove unneeded space [ Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx> ] ---------------------------------------------------------------------------- 2 files changed, 2 insertions(+), 1 deletion(-) src/kits/interface/Menu.cpp | 1 + src/kits/interface/PictureButton.cpp | 2 +- ############################################################################ Commit: c29f2d22a9ebf0066cf2a146aff98e7fe0b20d76 URL: http://cgit.haiku-os.org/haiku/commit/?id=c29f2d2 Author: Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx> Date: Fri Oct 25 19:40:13 2013 UTC Ticket: https://dev.haiku-os.org/ticket/9863 Close the menu on keypress. After _InvokeItem(), call QuitTracking() to close the menu. Incidentally this also seems to fix #9863. ---------------------------------------------------------------------------- diff --git a/src/kits/interface/Menu.cpp b/src/kits/interface/Menu.cpp index c80d4da..e94ee76 100644 --- a/src/kits/interface/Menu.cpp +++ b/src/kits/interface/Menu.cpp @@ -584,6 +584,7 @@ BMenu::KeyDown(const char* bytes, int32 numBytes) continue; _InvokeItem(item); + _QuitTracking(false); break; } break; ############################################################################ Revision: hrev46285 Commit: 2be66b5125f0ff7bf653463f391c9cafcf0d8185 URL: http://cgit.haiku-os.org/haiku/commit/?id=2be66b5 Author: Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx> Date: Fri Oct 25 19:42:19 2013 UTC Remove unneeded space ---------------------------------------------------------------------------- diff --git a/src/kits/interface/PictureButton.cpp b/src/kits/interface/PictureButton.cpp index 9c82099..2b3b554 100644 --- a/src/kits/interface/PictureButton.cpp +++ b/src/kits/interface/PictureButton.cpp @@ -71,7 +71,7 @@ BPictureButton::~BPictureButton() BArchivable* BPictureButton::Instantiate(BMessage* data) { - if ( validate_instantiation(data, "BPictureButton")) + if (validate_instantiation(data, "BPictureButton")) return new (std::nothrow) BPictureButton(data); return NULL;