[haiku-commits] Re: haiku: hrev46251 - src/kits/shared src/kits/tracker src/apps/webpositive headers/private/shared

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 18 Oct 2013 14:46:42 -0400

On Fri, Oct 18, 2013 at 2:11 PM, Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
> 2013/10/18 John Scipione <jscipione@xxxxxxxxx>:
>>> I don't really get why the "=" comes into play here. I would search
>>> for a "+" on a modifier and return the corresponding normal character
>>> to be used on shortcut creation. Please explain.
>>
>> Well, it's kind of 6 one way, half a dozen the other, isn't it? Either
>> way you need to look for '+' and '=' in the same key.
>>
>> Perhaps in this specific case your way makes more sense, but,
>> BKeymap::GetModifiedCharacters() would be a bit more awkward in the
>> general case, which is, pass in the normal key, and the modifiers you
>> want, get out the equivalent modified characters, IMHO of course.
>
> Why do you want only keys which happen to have a '=' as a normal key
> to have the zoom-in behavior, and not all keys which have '+' as a
> shifted key?

Because we don't want to clober other shortcuts that have '+' in the
shifted position. We know that Command+'=' isn't assigned to any other
shortcut in these apps, but, we can't make the same assurances for
whatever key is in the normal map with '+' in the shift map for a
keymap.

For example, let's say that in your keymap '+' in the shift map is in
same position as 'R' in the normal map we don't want to overwrite the
Command+'R' which does refresh in WebPositive.

Other related posts: