[haiku-commits] Re: haiku: hrev46226 - src/add-ons/kernel/file_systems/cdda

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 14 Oct 2013 17:55:37 +0200

2013/10/14  <axeld@xxxxxxxxxxxxxxxx>:
> a2d3d3a: cdda: got rid of kernel_cpp.h - it should not be used.
>
>   * It's "new" operator does not fail or throw on allocation problems, but
>     just lets the constructor do its work (and likely crash because of
>     accessing a null pointer).

> @@ -432,7 +431,7 @@ read_attributes(int fd, Inode* inode)
>                 size = B_BENDIAN_TO_HOST_INT32(size);
>                 name[length] = '\0';
>
> -               Attribute* attribute = new Attribute(name, type);
> +               Attribute* attribute = new(std::nothrow) Attribute(name, 
> type);
>                 if (attribute->IsProtectedNamespace()) {
>                         // Attributes in the protected namespace are handled 
> internally
>                         // so we do not load them even if they are present in 
> the

This is likely to fail when attribute is null.

Bye,
Jérôme

Other related posts: