[haiku-commits] haiku: hrev46084 - in src/apps/debugger/user_interface/gui: team_window inspector_window
- From: anevilyak@xxxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 17 Sep 2013 11:18:57 +0200 (CEST)
hrev46084 adds 2 changesets to branch 'master'
old head: f2479c22a8fc50b3086c63d2c823621d39c183ba
new head: 4ce4250be08c334d7aa6e9008d0108afb7bdbf0b
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=4ce4250+%5Ef2479c2
----------------------------------------------------------------------------
a82e311: Debugger: Fix calculation in MemoryView.
- The offset calculation for mapping the current point wasn't taking
into account the number of bytes per hex block, causing it to be
proportionally further off if one switched to 16/32/64-bit hex mode.
Gets mouse selection working properly in said modes.
4ce4250: Debugger: Fix RegistersView context menu.
- Always grab the address value from the actual register value column,
rather than the one that's in fact under the mouse. Fixes the "Inspect"
item sending you to inspect address 0 if you happened to right click over
the register name rather than the value.
[ Rene Gollent <anevilyak@xxxxxxxxx> ]
----------------------------------------------------------------------------
2 files changed, 2 insertions(+), 2 deletions(-)
.../debugger/user_interface/gui/inspector_window/MemoryView.cpp | 2 +-
src/apps/debugger/user_interface/gui/team_window/RegistersView.cpp | 2 +-
############################################################################
Commit: a82e311cf19cd5493798b6164e2246f1b78c8bfa
URL: http://cgit.haiku-os.org/haiku/commit/?id=a82e311
Author: Rene Gollent <anevilyak@xxxxxxxxx>
Date: Tue Sep 17 09:14:38 2013 UTC
Debugger: Fix calculation in MemoryView.
- The offset calculation for mapping the current point wasn't taking
into account the number of bytes per hex block, causing it to be
proportionally further off if one switched to 16/32/64-bit hex mode.
Gets mouse selection working properly in said modes.
----------------------------------------------------------------------------
diff --git
a/src/apps/debugger/user_interface/gui/inspector_window/MemoryView.cpp
b/src/apps/debugger/user_interface/gui/inspector_window/MemoryView.cpp
index 8b5e782..7f51115 100644
--- a/src/apps/debugger/user_interface/gui/inspector_window/MemoryView.cpp
+++ b/src/apps/debugger/user_interface/gui/inspector_window/MemoryView.cpp
@@ -677,7 +677,7 @@ MemoryView::_GetOffsetAt(BPoint point) const
float blockWidth = (charsPerBlock * 2 + 1) * fCharWidth;
int32 containingBlock = int32(floor(point.x / blockWidth));
- return fHexBlocksPerLine * lineNumber
+ return fHexBlocksPerLine * charsPerBlock * lineNumber
+ containingBlock * charsPerBlock;
}
############################################################################
Revision: hrev46084
Commit: 4ce4250be08c334d7aa6e9008d0108afb7bdbf0b
URL: http://cgit.haiku-os.org/haiku/commit/?id=4ce4250
Author: Rene Gollent <anevilyak@xxxxxxxxx>
Date: Tue Sep 17 09:17:31 2013 UTC
Debugger: Fix RegistersView context menu.
- Always grab the address value from the actual register value column,
rather than the one that's in fact under the mouse. Fixes the "Inspect"
item sending you to inspect address 0 if you happened to right click over
the register name rather than the value.
----------------------------------------------------------------------------
diff --git a/src/apps/debugger/user_interface/gui/team_window/RegistersView.cpp
b/src/apps/debugger/user_interface/gui/team_window/RegistersView.cpp
index 031bb6b..9dafae4 100644
--- a/src/apps/debugger/user_interface/gui/team_window/RegistersView.cpp
+++ b/src/apps/debugger/user_interface/gui/team_window/RegistersView.cpp
@@ -242,7 +242,7 @@ RegistersView::TableCellMouseDown(Table* table, int32
rowIndex,
return;
BVariant value;
- if (!fRegisterTableModel->GetValueAt(rowIndex, columnIndex, value))
+ if (!fRegisterTableModel->GetValueAt(rowIndex, 1, value))
return;
BPopUpMenu* menu = new(std::nothrow)BPopUpMenu("Options");
Other related posts:
- » [haiku-commits] haiku: hrev46084 - in src/apps/debugger/user_interface/gui: team_window inspector_window - anevilyak
