[haiku-commits] Re: haiku: hrev46012 - headers/private/screen_saver src/kits/screensaver src/preferences/screensaver
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Sun, 22 Sep 2013 16:54:14 -0400
On Sunday, September 22, 2013, Matt Madia wrote:
> On 9/22/13, John Scipione <jscipione@xxxxxxxxx <javascript:;>> wrote:
> > On Sunday, September 22, 2013, Matt Madia wrote:
> >> On 9/5/13, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx
> >> <javascript:;><javascript:;>> wrote:
> >> > Am 05/09/2013 00:39, schrieb John Scipione:
> >>
> >> >> Perhaps my solution is a work-around and not a proper fix, but, it's
> >> >> one hell of a workaround because it transforms the screensaver app
> >> >> from one that stuttered and locked up easily to one that works well,
> >> >
> >> > You just replaced a bad bug with a minor bug. Still a bug.
> >> >
> >> > Not taking the time to investigate problems but to work around them
> >> > drastically worsens the code quality over time, and that both for the
> >> > end user experience as well as for the developer who wants to
> >> > understand
> >> > it.
> >
> >> In that case, should this be reverted until a proper fix is found?
> >
> > I would advise NOT reverting since the app would be made barely usable
> > again, locking up with little difficulty.
>
> The observed policy has been to not commit shoddy code, but to commit
> properly functioning code. A search of "revert" in the haiku-commits
> mailing list shows numerous examples (from multiple developers) who
> abide by this policy.
>
Ok fair enough ill revert when I get a chance, although I really don't
think the code is "shotty".
Other related posts:
