[haiku-commits] Re: haiku: hrev46004 - src/kits/media headers/os/media src/apps

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 31 Aug 2013 23:36:17 +0200

On 08/31/2013 10:58 PM, John Scipione wrote:
On Sat, Aug 31, 2013 at 4:16 PM, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
1. Library code should not print anything, unless it is supposed to.

Okay, I'll hide the printf's behind a #ifdef TRACE_MEDIA_TRACK guards.
I was fooled because the library printf's elsewhere. My bad.

2. Calling debugger() is just fine to complain about programming errors.

You really think it's okay to drop the user into the debugger when
they try to play a bad video file? That's pretty harsh, the program
can handle a bad file.

No, this code shouldn't even be executed when the decoder failed. What's the point of checking the format, if the decoder didn't set it?

CU, Ingo

Other related posts: