[haiku-commits] haiku: hrev45886 - src/apps/debugger/dwarf
- From: anevilyak@xxxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 20 Jul 2013 23:47:53 +0200 (CEST)
hrev45886 adds 1 changeset to branch 'master'
old head: 3436a840a38c64f51b3d0c065b1899bc9526645d
new head: a326afa3fca2ccb841b8e8ff6b7a8663eec1dc83
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=a326afa+%5E3436a84
----------------------------------------------------------------------------
a326afa: Debugger: Rework DIETypeUnit.
DIETypeUnit now inherits from DIECompileUnitBase in order to handle
things like setting the language info properly. This was previously
missing and would lead to occasional crashes with DWARF4.
[ Rene Gollent <anevilyak@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev45886
Commit: a326afa3fca2ccb841b8e8ff6b7a8663eec1dc83
URL: http://cgit.haiku-os.org/haiku/commit/?id=a326afa
Author: Rene Gollent <anevilyak@xxxxxxxxx>
Date: Sat Jul 20 21:33:10 2013 UTC
----------------------------------------------------------------------------
2 files changed, 1 insertion(+), 20 deletions(-)
src/apps/debugger/dwarf/DebugInfoEntries.cpp | 11 -----------
src/apps/debugger/dwarf/DebugInfoEntries.h | 10 +---------
----------------------------------------------------------------------------
diff --git a/src/apps/debugger/dwarf/DebugInfoEntries.cpp
b/src/apps/debugger/dwarf/DebugInfoEntries.cpp
index 93ff1dc..1f8a08b 100644
--- a/src/apps/debugger/dwarf/DebugInfoEntries.cpp
+++ b/src/apps/debugger/dwarf/DebugInfoEntries.cpp
@@ -2536,8 +2536,6 @@ DIESharedType::AddAttribute_decl_column(uint16
attributeName,
DIETypeUnit::DIETypeUnit()
- :
- fLanguage(0)
{
}
@@ -2549,15 +2547,6 @@ DIETypeUnit::Tag() const
}
-status_t
-DIETypeUnit::AddAttribute_language(uint16 attributeName,
- const AttributeValue& value)
-{
- fLanguage = value.constant;
- return B_OK;
-}
-
-
// #pragma mark - DIETemplateTypeParameterPack
diff --git a/src/apps/debugger/dwarf/DebugInfoEntries.h
b/src/apps/debugger/dwarf/DebugInfoEntries.h
index 66b4818..0b8b700 100644
--- a/src/apps/debugger/dwarf/DebugInfoEntries.h
+++ b/src/apps/debugger/dwarf/DebugInfoEntries.h
@@ -1606,19 +1606,11 @@ private:
};
-class DIETypeUnit : public DebugInfoEntry {
+class DIETypeUnit : public DIECompileUnitBase {
public:
DIETypeUnit();
virtual uint16 Tag() const;
-
- uint16 Language() const
{ return fLanguage; }
-
- virtual status_t AddAttribute_language(uint16
attributeName,
- const
AttributeValue& value);
-
-private:
- uint16 fLanguage;
};
Other related posts:
- » [haiku-commits] haiku: hrev45886 - src/apps/debugger/dwarf - anevilyak
