[haiku-commits] Re: haiku: hrev45802 - in src: apps/debugger/user_interface/gui/team_window kits/interface

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 29 Jun 2013 13:31:06 -0400

On 6/29/13, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> Since the "if" block returns, there shouldn't be an "else".

[...]

> I would organize the control flow like this:

[...]

Sounds reasonable, will adjust. Thanks for the review :)

[...]

> Some additional handling might needed here. Not that many users will be
> fast enough to select another stack frame in the short time window, but
> we can't take chances ... :-)

I guess the simplest thing there would just be to ignore the selection
change if there's currently a trace runner active?

Regards,

Rene

Other related posts: