hrev45787 adds 1 changeset to branch 'master' old head: ea27e95f489fbb29cedad74788ee607b331f8a2f new head: 4dff02682c49ce3c55d8c9d8c96f92a84a526ad2 overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=4dff026+%5Eea27e95 ---------------------------------------------------------------------------- 4dff026: Revert "debuganalyzer: Fix double free. CID 992566" This reverts commit ea27e95f489fbb29cedad74788ee607b331f8a2f. * AnEvilYak pointed out that this was a false positive as BObjectList can optionally delete on remove. * I'll add a penny to the bitcoin bad commit jar :) [ Alexander von Gluck IV <kallisti5@xxxxxxxxxxx> ] ---------------------------------------------------------------------------- Revision: hrev45787 Commit: 4dff02682c49ce3c55d8c9d8c96f92a84a526ad2 URL: http://cgit.haiku-os.org/haiku/commit/?id=4dff026 Author: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx> Date: Mon Jun 24 21:29:04 2013 UTC ---------------------------------------------------------------------------- 1 file changed, 3 insertions(+), 1 deletion(-) src/apps/debuganalyzer/gui/table/Table.cpp | 4 +++- ---------------------------------------------------------------------------- diff --git a/src/apps/debuganalyzer/gui/table/Table.cpp b/src/apps/debuganalyzer/gui/table/Table.cpp index 2b2b9bc..2eb7b93 100644 --- a/src/apps/debuganalyzer/gui/table/Table.cpp +++ b/src/apps/debuganalyzer/gui/table/Table.cpp @@ -640,8 +640,10 @@ Table::TableRowsRemoved(TableModel* model, int32 rowIndex, int32 count) } for (int32 i = rowIndex + count - 1; i >= rowIndex; i--) { - if (BRow* row = fRows.RemoveItemAt(i)) + if (BRow* row = fRows.RemoveItemAt(i)) { RemoveRow(row); + delete row; + } } // re-index the subsequent rows