[haiku-commits] Re: haiku: hrev45727 - src/kits/interface headers/os/interface src/preferences/backgrounds src/preferences/screen

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 31 May 2013 10:04:23 -0400

On May 31, 2013, at 9:49 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:

> Am 31/05/2013 15:47, schrieb John Scipione:
>> On May 31, 2013, at 7:43 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
>>> Please revert. And if you don't know what you're doing, just don't.
>> In case you didn't already see it I've already reverted this change.
>> This one was definitely premature and I didn't think it through all the way 
>> before pushing. Sorry for the inconvenience.
> 
> Alright, I did not see you reverted it, or else I may have managed to contain 
> myself :-)

No problem, for the most part what you said was correct and I understand your 
alarm.

I was trying to solve the problem of getting the top borders of the BBoxes in 
Screen and Backgrounds to line up like they did in R5 without resorting to 
hacks.

I thought i had a decent solution but when I double checked with BeOS R5, what 
I did was definitely not kosher. I should have checked that BEFORE pushing 
though and that I take the blame for that.

I did end up solving the problem in Screen though at least in a more sensible 
way than it was before so I'm happy about that at least.

Other related posts: