[haiku-commits] Re: haiku: hrev45727 - src/kits/interface headers/os/interface src/preferences/backgrounds src/preferences/screen
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Fri, 31 May 2013 09:47:31 -0400
On May 31, 2013, at 7:43 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
>> On May 31, 2013 at 2:43 AM jscipione@xxxxxxxxx wrote:
>> 39899cf: BBox: Always offset the top border by the same amount
>>
>> ...so that the top border of BBox's with no labels, BBox's with
>> text labels, and BBox's with BControl labels will all line up.
>
> This is bogus. Can you please either work in a private branch until your work
> is
> ready, and, in case you change the behaviour of standard widgets, to ask on
> the
> development list first?
> Because your changes don't make sense, will look ugly, and are completely
> broken.
>
> 1) You cannot overwrite a virtual after the fact, just like this. This is
> where
> Perform() comes into play.
> 2) If a BBox is used without a label (which may happen quite often) there is
> now
> a strange top offset.
> 3) The font size is completely irrelevant to the top border offset. Only the
> height of the view you add there is.
> 4) This breaks compatibility with BeOS.
>
> Please revert. And if you don't know what you're doing, just don't.
In case you didn't already see it I've already reverted this change.
This one was definitely premature and I didn't think it through all the way
before pushing. Sorry for the inconvenience.
Other related posts:
