[haiku-commits] Re: haiku: hrev45685 - src/system/runtime_loader src/system/libroot/os src/system/libroot/posix/malloc headers/private/system headers/os/kernel
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 15 May 2013 14:39:51 +0200 (CEST)
> On May 15, 2013 at 12:07 AM pdziepak@xxxxxxxxxxx wrote:
> + __gCompatibilityMode
> + = __gRuntimeLoader->abi_version < B_HAIKU_ABI_GCC_2_HAIKU;
Making this an 'int' isn't that nice. Why not simply have a __gABIVersion
instead?
'compatibility mode' isn't really a helpful name IMO, anyway.
Otherwise nice changes!
> +void
> +set_abi_version(int abi_version)
> +{
> + if (gRuntimeLoader.abi_version == 0
> + || gRuntimeLoader.abi_version > abi_version) {
> + gRuntimeLoader.abi_version = abi_version;
> + }
> +}
Maybe add a comment like:
/*! Is called for all images, and sets the minimum ABI version found to the
gRuntimeLoader.abi_version field.
*/
Bye,
Axel.
Other related posts:
