[haiku-commits] Re: haiku: hrev45638 - src/kits/interface
- From: Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 7 May 2013 10:21:28 +0200
2013/5/7 Stephan Aßmus <superstippi@xxxxxx>:
> On 07.05.2013 02:57, Jessica Hamilton wrote:
>> I think you have to give him a bit of credit for even tackling the menu
>> code. It is one hairy mess of inter-dependent classes! Perhaps a bit
>> more validation of the changes might've helped reduce the commit noise,
>> but it is UI code, and not all changes are predictable. The tangled web
>> that is the menu code especially so.
>
>
> Definitely. And I think I was bitten, too, by thinking something should
> happen in one class and for some non-immediately-obvious reason it happened
> in another...
I think the big problem is that the OpenTracker code is very messy,
and also that we lack consensus in UI design. Most discussions would
occur no matter what, nothing provokes bikeshed discussions like UI. I
think this is healthy as long as focus stays on the topic.
When it comes to code and design decisions he's not an expert yet, but
if we only want experts we will never get new blood. We have to have
reasonable expectations for those coming in, it is a long term
strategy.
Also the patch-workflow don't work for someone who does:
All-time Commits: 587
12-Month Commits: 432
30-Day Commits: 108
According to http://www.ohloh.net/p/haiku/contributors/14598593885485
Personally I think we should give more credit to John for working so
hard in a part of Haiku that I consider a 'minefield' both because
everyone have different opinions on UI and the very stateful
complicated code that UI is.
Also John is discussing a lot on IRC, so he does put in effort to
validate things beforehand.
(I'm actually quite impressed with John's asbestos suit, which seems
to work very well.)
/Fredrik Holmqvist, TQH
Other related posts:
