[haiku-commits] Re: haiku: hrev45638 - src/kits/interface
- From: Lrrr Of Omicron Persei 8 <lrrr.of.omicronpersei8@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 6 May 2013 19:25:17 -0600
On May 6, 2013 6:57 PM, "Jessica Hamilton" <jessica.l.hamilton@xxxxxxxxx>
wrote:
>
> On 7 May 2013 10:12, Matt Madia <mattmadia@xxxxxxxxx> wrote:
>> Does anyone else get the feeling that maybe perhaps John was indeed
>> not yet ready for commit access?
>
>
> I think you have to give him a bit of credit for even tackling the menu
code. It is one hairy mess of inter-dependent classes! Perhaps a bit more
validation of the changes might've helped reduce the commit noise, but it
is UI code, and not all changes are predictable. The tangled web that is
the menu code especially so.
If he's working on code that he is unfamiliar with then he should be asking
for review before pushing them to master. I've seen all of the top devs
open tickets or start email threads asking for advice or review in the past.
I also think his defensive attitude when being asked to change something by
senior devs is becoming a bit annoying.
Not that I have any say in the matter, but, if a good portion of his
commits need corrections beyond style changes then perhaps he is too quick
to pull the trigger on git push and needs to be submitting them as patches
to trac.
--Chris
Other related posts:
