[haiku-commits] Re: haiku: hrev45638 - src/kits/interface
- From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 7 May 2013 12:57:05 +1200
On 7 May 2013 10:12, Matt Madia <mattmadia@xxxxxxxxx> wrote:
> On 5/6/13, jscipione@xxxxxxxxx <jscipione@xxxxxxxxx> wrote:
> > hrev45638 adds 1 changeset to branch 'master'
> > old head: 13cec3021167821f38dbd64e0bfda69a8c5c3a9c
> > new head: c1a7e89fc235363e91d79eb547e92e9e16efd5e5
> > overview:
> http://cgit.haiku-os.org/haiku/log/?qt=range&q=c1a7e89+%5E13cec30
> >
> >
> ----------------------------------------------------------------------------
> >
> > c1a7e89: Put the label truncation code back in BMenuItem.
> >
> > Just a few commits ago I moved the label truncation code out of
> > BMenuItem and into BMCMenuBar because the truncation had to happen
> > outside of BMenuItem. Turns out, that wasn't true so I'm moving the
> > label truncation back into BMenuItem and removing the _DrawItems()
> > method from BMCMenuBar.
>
> Does anyone else get the feeling that maybe perhaps John was indeed
> not yet ready for commit access?
>
I think you have to give him a bit of credit for even tackling the menu
code. It is one hairy mess of inter-dependent classes! Perhaps a bit more
validation of the changes might've helped reduce the commit noise, but it
is UI code, and not all changes are predictable. The tangled web that is
the menu code especially so.
Jessica
Other related posts:
