[haiku-commits] Re: haiku: hrev45603 - in src/add-ons/kernel/file_systems: btrfs ext2

  • From: Clemens <clemens.zeidler@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 03 May 2013 11:45:30 +1200

On Fri, 03 May 2013 09:45:30 +1200, <korli@xxxxxxxxxxxxxxxx> wrote:

hrev45603 adds 2 changesets to branch 'master'
old head: 8a43cad2ef51b227d80be6e20f37b14c2a0dbde4
new head: c33b645d33c3c568b0371e13ee527676bf4931db
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=c33b645+%5E8a43cad

----------------------------------------------------------------------------

795f13d: btrfs: Return more than a single dirent at a time in btrfs_read_dir().
 * similar to what mmlr did in hrev45575 for bfs.

c33b645: ext2: Return more than a single dirent at a time in ext2_read_dir().
 * similar to what mmlr did in hrev45575 for bfs.

[ Jerome Duval <jerome.duval@xxxxxxxxx> ]

this is more an informal question. I have the impression that there is quit some code duplication (or at least very similar code) going on in the file systems. For example, all the Volume, INode classes... Do you think it is possible to refactor this and and make a higher C++ fs interface?

Could stuff such as access rights and notification services be put into this C++ interface? If I'm correct this is handled by each fs individually. I find it a bit odd that such stuff has to be reimplemented each time. Its quite error prone isn't it?

thanks,
        Clemens




Other related posts: