[haiku-commits] Re: haiku: hrev45589 - in src: apps/workspaces apps/deskcalc preferences/locale apps/processcontroller apps/webpositive

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Tue, 30 Apr 2013 20:25:50 -0400

On Tue, Apr 30, 2013 at 5:07 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> Am 30/04/2013 22:14, schrieb pulkomandy@xxxxxxxxxxxxx:
>
>>     * Add a static GetWindow method that returns the existing about
>> window, if there
>>    is one, or creates one if there is not. A boolean can be set to tell
>> the caller
>>    what happened,
>
>
> Now that I see it in action, I must say this interface really sucks.
> Please just get rid of the singleton again, and make that bloody thing
> modal.

I'm just going to add a little fuel onto this fire. I just was
updating BFilePanel and guess what happens when you close a BFilePanel
window? That's right, it hides the window instead of destroying it! I
even verified this by looking at the threads in Activity Monitor,
they're still there hanging around after the window is "gone". And, it
pulls the window to the current workspace when you open it again from
a different workspace just like I did in BAboutWindow.

I just wanted to point out that hiding a window on close instead of
destroying it is the 100% Be approved™ officially sanctioned way of
handling BFilePanels.

Other related posts: