[haiku-commits] Re: haiku: hrev45452 - src/apps/deskbar

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Sun, 7 Apr 2013 11:31:29 -0400

On Apr 7, 2013, at 7:54 AM, Stephan Aßmus <superstippi@xxxxxx> wrote:

> Hi,
> 
> On 07.04.2013 04:13, jscipione@xxxxxxxxx wrote:
>> de49a05: Update expander arrows to point right or down (if expanded)
>> 
>>   ... like BeOS R5. I looked in the commmit logs for this one and there 
>> wasn't really any
>>   explination for why this got changed, so, I'm changing it back to the way 
>> it was in R5 which
>>   is right arrow for unexpanded, down arrow for expanded. Please yell at me 
>> if this change
>>   was intentional.
> 
> If memory serves, I changed it and it was intentional. The item expands down 
> and collapses up. An icon should represent the action that will happen, so I 
> thought the symbol should point down when the action is to expand down when 
> you click it. Same with pointing up when the action is to collapse.

Thank you so much for chiming in with an explanation. Looking at the commit log 
it looked like you were converting the arrows to use be_control_look and you 
changed the arrow direction at the same time. I couldn't tell if you changed 
the arrow direction on purpose or not and there was no explanation in the text 
either.

> That being said, I think this is not consistent throughout the system, for 
> example Tracker and Installer have groups that are expandable and work the 
> way you changed it now. At the same time, there are other places, most 
> notablly Windows' tree views that also have the arrows like you changed them 
> to be.

I would really prefer this be consistent either way... And I have an even 
crazier idea of adding a tree mode to Tracker like in Windows Explorer or Mac 
OS Tracker. I was using System 7 the other day and it has a tree view in the 
spatial Finder there. It's one of those features I really miss.

> Not sure how to decide here, but at least now you know why I made it the way 
> it was.

Thank you again for your explanation. If you'd like I could start a thread on 
the development mailing list about this to get a few more opinions.

Other related posts: