[haiku-commits] Re: haiku: hrev45444 - headers/private/app headers/os/interface src/servers/app src/kits/interface

  • From: pulkomandy@xxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 06 Apr 2013 09:05:57 +0200

>   I've added a B_COLOR_WHICH_COUNT constant to the color_which enum which 
>   should
>   be updated to point to the newest color constants as new ones are added. I
>   reworked ServerReadOnlyMemory to use this constant instead of using to the
>   current largest color constant directly. If you use B_COLOR_WHICH_COUNT to
>   refer to a color in your code expect to get unpredictable and nonsensical
>   results. Most likely you'll get an undefined result which will return 
>   black
>   but don't depend on it.

You just explained why this was not a public constant before. We don't want 
to leak this internal implementation detail into a public header, and 
moreover pollute the global namespace with it. This is why we were using a 
private constant in the implementation, not a public one.

-- 
Adrien.

Other related posts: