[haiku-commits] Re: haiku: hrev45443 - headers/private/app src/kits/interface src/preferences/appearance src/bin headers/os/interface

  • From: pulkomandy@xxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 06 Apr 2013 09:03:30 +0200

On 2013-04-06 at 01:29:31 [+0200], jscipione@xxxxxxxxx wrote:
> hrev45443 adds 1 changeset to branch 'master'
> old head: 631624fb010bb76278e1a291a578cf802dc3eb77
> new head: 9f24981a56edba10807b550b521563b0cadd12c7
> overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=9f24981+%5E631624f
> 
> ----------------------------------------------------------------------------
> 
> 9f24981: Add B_SCROLL_BAR_THUMB_COLOR constant.
>   
>   This allows you to change the scrollbar thumb color in Appearance 
>   preferences.
>   The default color is 216, 216, 216 so the scroll bar thumb looks the same 
>   by
>   default. Perhaps someday this can be updated to something a bit more 
>   colorful.

I thought the idea was to remove as much constants as possible and use a 
single base color (or a small set) to compute all the others ?
Do we really want users to be able to do things like
http://johntopley.com/images/posts/2010/11/20/windows_311.png ?

Note that besides the possibility of users picking very ugly colors, there's 
also the problem that this makes it harder to properly design and test custom 
widgets in an application. You're never sure you used the correct constant if 
there are too much of them. You have to test every possible colorscheme to 
make sure your widget looks right and is readable in all cases.
-- 
Adrien.

Other related posts: