[haiku-commits] Re: haiku: hrev45317 - in src: apps/deskbar preferences/time

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 25 Feb 2013 12:58:24 +0100

Hi,

Am 23.02.2013 20:50, schrieb jscipione@xxxxxxxxx:
############################################################################

Revision:    hrev45317
Commit:      ca00f398da7f8cd19698205769fdf8cb6f2bde83
URL:         http://cgit.haiku-os.org/haiku/commit/?id=ca00f39
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Sat Feb 23 19:41:54 2013 UTC

Ticket:      https://dev.haiku-os.org/ticket/9469

Fix Deskbar clock show/hide when Deskbar is hidden.

Bug #9469 happens because I set the showClock checkbox or not based on whether
or not the clock is currently hidden. This works most of the time, but if
Deskbar is hidden the clock is also considered to be hidden and that isn't what
I want in this case.

The solution is to override BView's Show(), Hide(), and IsHidden() methods
in TimeView to ignore whether or not the window is hidden when considering if
the clock is hidden.

The BView::IsHidden() method has a BView* parameter "looking from". You can pass the TimeView pointer itself to IsHidden() and this should already ignore whether any parent views or the window itself are hidden.

Best regards,
-Stephan


Other related posts: