[haiku-commits] Re: haiku: hrev45273 - in src: apps/deskbar kits/tracker

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 12 Feb 2013 13:11:32 +0100 (CET)

On February 12, 2013 at 4:08 AM jscipione@xxxxxxxxx wrote:
>  TrackerSettingsWindow::TrackerSettingsWindow()
>    :
>    BWindow(BRect(80, 80, 450, 350), B_TRANSLATE("Tracker preferences"),
>            B_TITLED_WINDOW, B_NOT_MINIMIZABLE | B_NOT_RESIZABLE
> -          | B_NO_WORKSPACE_ACTIVATION     | B_NOT_ANCHORED_ON_ACTIVATE
>            | B_ASYNCHRONOUS_CONTROLS | B_NOT_ZOOMABLE
>            | B_AUTO_UPDATE_SIZE_LIMITS)
>  {
> @@ -184,6 +184,12 @@ TrackerSettingsWindow::Show()
> 
>            Unlock();
>    }
> +
> +  if (IsHidden()) {
> +          // move to current workspace
> +          SetWorkspaces(B_CURRENT_WORKSPACE);
> +  }

Unless I'm completely mistaken, please revert this change. What do you think the
above flag is supposed to do?
If it doesn't as advertized, it should be fixed, not worked around.
If the intention is to keep it on the same workspace when it's activated, but
open, the change is valid, of course, however, it still works around the root
cause of bug #8000.

Bye,
   Axel.

Other related posts: