[haiku-commits] Re: haiku: hrev45055 - src/apps/debugger/dwarf

  • From: Alex Smith <alex@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 22 Dec 2012 08:40:52 +0000

On 22 December 2012 04:33, <anevilyak@xxxxxxxxx> wrote:

> 54531e9: Allow CfaContext to be initialized lazily.
>
> 96a4619: Make use of augmentation if available.
>
>   - Pull out a _ParseCIEAugmentation() from _ParseCIE().
>
>   - If .eh_frame is being used, do a quick parse of the CIE up front
>     in order to determine the augmentation (if any), and use it to
>     retrieve addresses in the appropriate format. This fixes stack
>     unwinding on x86-64, and possibly other cases where the address
>     encoding didn't correspond to architectural target size in absolute
>     address format.
>

Great! Just tested it, everything seems to be working fine in Debugger now.
There's still the TODO for ArchitectureX8664::CreateStackFrame that's
getting hit when the unwind reaches _start, so I'll try implementing that
at some point (even though it'll only work with -fno-omit-frame-pointer),
and there's a couple of other TODOs I put in that I need to look at.

Thanks,
Alex

Other related posts: