[haiku-commits] Re: haiku: hrev45039 - in src: apps/deskbar kits/tracker

  • From: pulkomandy@xxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 29 Dec 2012 15:32:01 +0100

> ee70bd8: Hide and show Deskbar preference window
>   
>   ... instead of destroying and creating it each time.
>   
>   This is taking another page from Tracker's book. It allows the prefs
>   window to maintain it's current state as long as the application
>   remains open. Since both Tracker and Deskbar are meant to always be
>   open this means that the state is kept all the time unless the app
>   crashes, quite useful.

It seems changes to deskbar settings aren't saved to disk anymore. At least 
for me, it resets to default settings on each reboot.

Try this:
* change some settings (bigger icons, enable expando mode, etc
* hey Deskbar quit
* Team Monitor > restart the desktop
For me Deskbar goes back to default settings.

Also, the Preferences window lacks a revert button. (not your fault, it was 
not there before either). Since the revert button should revert settings to 
the state they were when the window was shown, it may actually be simpler to 
destroy and recreate it each time. The state of the window is derived from 
the settings, so it's easy to recreate when opening the window again, right ?

The BBox around the controls should be removed, and I also think that using 
tabs would be better when there are so few items with single-word names. The 
list on the side wastes space.

-- 
Adrien.

Other related posts: