[haiku-commits] Re: haiku: hrev45039 - in src: apps/deskbar kits/tracker
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 21 Dec 2012 16:48:18 +0100
Am 21/12/2012 02:00, schrieb jscipione@xxxxxxxxx:
ee70bd8: Hide and show Deskbar preference window
... instead of destroying and creating it each time.
This is taking another page from Tracker's book. It allows the prefs
window to maintain it's current state as long as the application
remains open. Since both Tracker and Deskbar are meant to always be
open this means that the state is kept all the time unless the app
crashes, quite useful.
Why would that be useful?
1. It wastes memory.
2. Returning false in QuitRequested() will prevent you from quitting the
Deskbar.
3. Your QuitRequested() implementation is awfully complicated: it is
called from the message loop, so the looper is already locked.
Bye,
Axel.
Other related posts:
