[haiku-commits] Re: haiku: hrev44963 - src/add-ons/kernel/partitioning_systems/intel

  • From: Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 6 Dec 2012 20:52:02 +0100

2012/12/6 Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>:
> Am 05/12/2012 22:42, schrieb fredrik.holmqvist@xxxxxxxxx:
>
>> +               ERROR(("Error: Disk is GPT-formatted: "
>> +                       "GPT disks are currently unsupported.\n"));
>
>
> That should not be an ERROR() but a TRACE(). Also, the part after the ':'
> can be omitted completely. There is a GPT module that supports GPT, it's not
> and never will be the duty of the Intel module.

I changed to a error macro there so that you get a message when
makebootable fails instead of just an unknown error. This is still a
work in progress as we should support gpt disks (in makebootable) I
just wanted to add this to disable mishaps for anyone.

/Fredrik Holmqvist, TQH

Other related posts: