[haiku-commits] Re: haiku: hrev44946 - src/apps/expander

  • From: Landon Fuller <landonf@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 2 Dec 2012 09:46:54 -0500


On Dec 2, 2012, at 7:48 AM, zharik@xxxxxx wrote:

> 1 file changed, 27 insertions(+), 6 deletions(-)
> src/apps/expander/ExpanderWindow.cpp | 33 ++++++++++++++++++++++++++------
> 
> ----------------------------------------------------------------------------
> 
> diff --git a/src/apps/expander/ExpanderWindow.cpp 
> b/src/apps/expander/ExpanderWindow.cpp
> index 9ea6fdc..d667d57 100644
> --- a/src/apps/expander/ExpanderWindow.cpp
> +++ b/src/apps/expander/ExpanderWindow.cpp
> @@ -150,19 +150,40 @@ ExpanderWindow::ValidateDest()
>       BVolume volume;
>       if (!entry.Exists()) {
>               BAlert* alert = new BAlert("destAlert",
> -                     B_TRANSLATE("The destination folder does not exist."),
> -                     B_TRANSLATE("Cancel"), NULL, NULL,
> +                     B_TRANSLATE("Destination folder doesn't exist, 
> create?"),
> +                     B_TRANSLATE("Yes"), B_TRANSLATE("No"), NULL,
>                       B_WIDTH_AS_USUAL, B_EVEN_SPACING, B_WARNING_ALERT);
> -             alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE);
> -             alert->Go();


As per the HIG ('http://api.haiku-os.org/HIG/chapter11.html#id2538729'), should 
'Create' (or 'Create Directory') and 'Cancel' be preferred over 'Yes' / 'No' 
here?

Cheers,
-landonf

Other related posts: