[haiku-commits] Re: haiku: hrev44875 - in src: system/ldscripts/arm system/runtime_loader/arch/arm kits/debug/arch/arm .
- From: Axel DÃrfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 22 Nov 2012 20:33:58 +0100
On 11/22/2012 08:09 PM, ithamar.adema@xxxxxxxxxxxxxxxx wrote:
b190a54: activitymonitor: remove B_MAX_CPU_COUNT reference
It has no use, since we don't know its value and the list of colors
might be longer [...]
That is certainly true, thanks for correcting.
> (for example, for ARM currently B_MAX_CPU_COUNT is
only 1). The modula operator later on makes sure we keep within the
bounds of the kColors array anyway.
However, why would you want to set it to 1 for ARM? Even if we currently
(or in the foreseeable future) do not support SMP, there is no real
reason to restrict that one, especially because changing it is a binary
compatibility issue.
For future API rework, we should try to get rid of it, though, and use
getter functions that get a CPU number or ID.
Bye,
Axel.
Other related posts:
