[haiku-commits] Re: haiku: hrev44774 - src/bin
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Tue, 6 Nov 2012 01:04:24 -0500
On Mon, Nov 5, 2012 at 9:59 PM, Jessica Hamilton
<jessica.l.hamilton@xxxxxxxxx> wrote:
>
> New to the list, so hope this isn't out of place for small fixes :)
It is fine to make these kinds of comments here.
> Should move the closing } to end, remove semID and replace uses with sem.
I would have left this for AnEvilYak to fix except it broke the build
while I was performing a complicated rebase of a branch on top of
master and it seems like AnEvilYak has gone away for the evening.
I committed a fix for this in hrev44775.
I put the code inside the else branch, sorry if this is not correct.
As far as names go I went with 'id', both 'sem' and 'semID' seemed
like worse choices.
Other related posts:
