[haiku-commits] Re: haiku: hrev44761 - in src: data/keymaps add-ons/input_server/devices/keyboard

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Mon, 5 Nov 2012 13:10:09 -0500

On Mon, Nov 5, 2012 at 7:35 AM, <axeld@xxxxxxxxxxxxxxxx> wrote:

> hrev44761 adds 2 changesets to branch 'master'
> old head: 17ad59afd3b25f230efd7231a3315e344ef73ae0
> new head: 634feff0e97e3d0e60976eb7a27938743440506b
>
>
> ----------------------------------------------------------------------------
>
> 095d038: Reverted hrev42962 - there is no right command key in US
> internatinal.
>
>   * This makes the keymap behave as in every other operating system.
>   * I don't really understand the original purpose of this change. Please
>     enlighten me (see #4464).
>

Sorry, I don't know the answer here, I am guessing it has something to do
with AltGr.


> 634feff: Cut off the trailing spaces from the key dump.
>
>   * Noticed these on the keymap changes made by John, however, I have no
>     idea how they did get there (the keymap command doesn't use this code).
>

The change I made in src/preferences/keymap/Keymap.cpp was this:

-       printf("\t");
+       fputs("\t", stdout);

so that the format string didn't have to be parsed.

There are likely spaces at the end of keymap lines to help out the BeOS
keymap parser, and this isn't needed anymore unless we care about BeOS
compatibility for keymap files.

John Scipione

Other related posts: