[haiku-commits] Re: haiku: hrev44733 - in src: preferences/appearance kits/interface
- From: Axel DÃrfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 04 Nov 2012 10:18:53 +0100
On 11/02/2012 03:31 PM, John Scipione wrote:
On Fri, Nov 2, 2012 at 6:40 AM, Axel DÃrfler <axeld@xxxxxxxxxxxxxxxx
<mailto:axeld@xxxxxxxxxxxxxxxx>> wrote:
FWIW I consider this an utterly superfluous feature. While there is
a certain usability difference that may rectify the arrow changes, I
would suggest to remove the dot/line knob styles again.
I'd like to open a dialog about this.
Pardon my rudeness, but if you actually wanted to open a dialog about
this, it would have been sensible to do that before actually putting any
effort into it. And even change the default look.
My main intension was not to
resurrect this admittedly puerile setting but to provide a scroll bar
knob, even one that does not resemble dots or lines and is not
configurable. However, since there was a setting for this on BeOS (and
corresponding data structures in Haiku to match), and there is a ticket
asking for the feature anyway (#6206), I figured it might be better to
just copy BeOS here.
Before doing such changes, don't you think Stippi had added those in his
original design if everybody wanted them? Or that anyone would have
tried to convince him to put them back in the last few years we didn't
have them anymore? Or that it was a conscious decision to remove them in
the first place?
Just because there is a ticket for it doesn't mean it's a good idea that
is shared by everyone, and should be implemented.
So far, we don't do theming, and this really doesn't belong anywhere
else.
The discussion on #6202 seemed to indicate that it belonged in
Appearance if anywhere.
That's certainly true, however, the feature itself should not be there
in the first place.
If you are so interested in doing something like that, please do a
proper theming support instead that can be enabled and played with by a
3rd party application.
It makes simply no sense to have such an option just for the scroll bar.
The ticket #6206 focusses on the double arrows for which I think a
setting makes more sense, as it affects usability, not the look.
While I liked the double arrow, I haven't really missed it in the last
couple of years either, which is a good indication that it's not really
an important feature.
BTW, we had those scroll bar settings a few years back, and removed
it -- for good reason.
According to #6206 it was removed in hrev17199 by you :)
Indeed, and just because 6 years passed since then, it doesn't make this
the wrong decision.
I'm glad you said that because I was not sure if there should be 2 blank
lines between data structures or not. Is that always true or only when
switching between one type and another? Meaning if you have 2 classes
defined in a header should there be 2 spaces between them as well?
It would assume it's always two blank lines between structs and classes.
But:
1) why make them public?
2) if they are public, they must have the B_ prefix.
I made the enum public because I needed to reference the constants in a
few places, I could have just reproduced the enum I suppose but I
figured it might be more useful to have it defined in just one place.
I'll put B_ in front of the constants or just make the enum private and
copy it.
If you only need it internally, it should be a private header.
Bye,
Axel.
Other related posts:
