[haiku-commits] Re: haiku: hrev44699 - src/add-ons/media/media-add-ons/equalizer
- From: Axel DÃrfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 16 Oct 2012 18:31:47 +0200
On 10/13/2012 10:05 PM, stpere@xxxxxxxxx wrote:
//EqualizerNode
-EqualizerNode::~EqualizerNode() {
The comment should be removed, too.
+
//BMediaNode
BMediaAddOn*
Same here.
-EqualizerNode::AddOn(int32 *id) const
+EqualizerNode::AddOn(int32* id) const
{
- if(fAddOn)
+ if (fAddOn)
fAddOn is a pointer, so it should be "if (fAddOn != NULL)" instead.
- if((BControllable::HandleMessage(message, data, size)!=B_OK) &&
+ if ((BControllable::HandleMessage(message, data, size) != B_OK) &&
(BBufferConsumer::HandleMessage(message, data, size) != B_OK) &&
(BBufferProducer::HandleMessage(message, data, size) != B_OK) &&
- (BControllable::HandleMessage(message, data, size) != B_OK) ) {
- BMediaNode::HandleMessage(message, data, size);
+ (BControllable::HandleMessage(message, data, size) != B_OK)) {
+ BMediaNode::HandleMessage(message, data, size);
'&&' goes to the beginning next line. The parentheses are superfluous.
- fPreferredFormat.u.raw_audio.channel_count =
media_raw_audio_format::wildcard.channel_count;
+ fPreferredFormat.u.raw_audio.channel_count =
+ media_raw_audio_format::wildcard.channel_count;
The '=' goes to the next line as well.
+
//BControllable
status_t
I think I get those comments now, however, they should be written like
this, with proper blank lines around them:
// #pragma mark - BControllable
This will cause Pe to show them in the function overview.
Bye,
Axel.
Other related posts:
