[haiku-commits] Re: haiku: hrev44693 - /
- From: Joseph Prostko <joe.prostko@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 14 Oct 2012 14:08:21 -0400
On Sun, Oct 14, 2012 at 12:40 PM, Urias McCullough
<umccullough@xxxxxxxxx> wrote:
> On Sun, Oct 14, 2012 at 9:30 AM, Joseph Prostko <joe.prostko@xxxxxxxxx> wrote:
>> *** Mismatching compiler versions between configure script and
>> *** ../buildtools/legacy/gcc/gcc/version.c
>> *** Did you perhaps update only one of haiku & buildtools?
>> So, to solve this, maybe build-cross-tools should be modified to do
>> some sort of comparison to see if 121012 is greater than or equal to
>> 111122 specified in configure before my change? If that's true, maybe
>> haikuRequiredLegacyVersion should be renamed to something like
>> haikuMinimumLegacyGCCVersion?
>
> Interesting - I always assumed it was a minimum-version check already
> that used some sort of logic to parse the filename...
Basically, the file version.c is grepped to see if it contains the
value set for haikuRequiredLegacyGCCVersion, and if it does, then the
script proceeds. If not, it's an error due to a mismatch in version
number. Actually, the file version.c could contain nothing or else
all garbage, and the same result would happen. That should never be
the case though, and it should probably just be assumed that that file
is valid always.
> I think that would be the preferred approach.
It's slightly more tricky than just renaming the variable, obviously,
but it could be done without much effort, and maybe introducing
another variable such as haikuActualLegacyGCCVersion (or something
more verbose like haikuLegacyGCCVersionFromVersionDotC) in
build_cross_tools. I'll likely come up with something later today,
and if there is a consensus that this modification should be done,
I'll modify configure and build_cross_tools as needed.
- joe
Other related posts:
