On 2012-09-04 2:12 pm, Ryan Leavengood wrote:
On Tue, Sep 4, 2012 at 2:04 PM, kallisti5 <kallisti5@xxxxxxxxxxx> wrote:Looking to get approval for this to be cherry-picked for R1A4. It resolves several bugs with swap files using too much disk space.I have already looked over Hamish's diff from #3723, so it shouldn't take me too long to review your changes. I've just taken a very cursory look so far. I can't guarantee it, but hopefully tonight I can spend some time on this as well as cherry picking other things into the r1alpha4 branch.
I just want to take a moment and say thank you for taking on this difficult
There are gui changes as well for the swap preflet... but I want to holdthose back for now to do more testing.OK, but I think it would be good to have those too. Though for the release we could hide the ability to change the volume of the swap file, in which case maybe the preflet changes aren't needed.
The main reason I held it back was the potential bugs the gui changes would introduce.. renaming the filesystem the swap was on would cause the chosen
device to go "rouge" causing manual config file editing.The changes in hrev44612 should enable the current preflet to function properly,
while getting the benefits of hrev44611 :)I have the hamish's preflet changes in my local branch.. i'll pound on them this evening to see if I can get things better tested and pushed to mainline. The kernel vm changes are pretty straight forward and I feel present a lower
regression risk. -- Alex