[haiku-commits] Re: haiku: hrev44567 - in src: preferences/appearance kits/interface preferences/locale

  • From: Ryan Leavengood <leavengood@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 20 Aug 2012 15:03:03 -0400

On Mon, Aug 20, 2012 at 2:49 PM, John Scipione <jscipione@xxxxxxxxx> wrote:
> I need a constant for both selected and unselected text. Should I make new
> constants for list items?

I kind of feel like we may already have an excessive number of
constants, and while I can understand Axel's argument I don't know if
we should add new constants. We could, but it is getting to the point
where the Appearance preflet needs to be a bit more advanced, or we
need to improve and integrate mmu_man's ThemeManager.

For example in this case even if we had different constants for menu
items and list items, the average use might be to have them match, and
that is hard to do with the current preflet.

Though it might be worse to have them both use the menu colors and
then the user has no way to change the list item colors without also
affecting menu colors. So maybe a new constant is more flexible.


Other related posts: