[haiku-commits] Re: haiku: hrev44567 - in src: preferences/appearance kits/interface preferences/locale

  • From: François Revol <revol@xxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 21 Aug 2012 01:24:08 +0200

On 21/08/2012 00:41, Ryan Leavengood wrote:

>> Make document backgrounds always white, why should this be
>> customizable? Perhaps keep it as a constant but hide it from the user.
> 
> Maybe for readability some people want to use a nice low contrast
> color scheme. Again I'd like to at least have it possible to change
> this, even if it is in an "Advanced" section.

Indeed some almost-blind people read much easier on black background.

As for list views, well in BeOS they used DOCUMENT colors, so they
should use the document selection color when we add it.
Interestingly the color schemes of menus vs drop-down vs listview is one
of the most evident differences between GUIs and toolkits...
some use the same color as menus, including for combos, while most use
the same as document color, and some also use document colors for
drop-downs because they are combo-boxes.

>> Keyboard navigation can stay as is. Shine and shadow can be eliminated.
> 
> Those latter two are indeed pretty obscure and I think only Tracker uses them.

Then are supposed to be used for the 3D-ish things...

>> Tooltip background color does not need to be customizable, eliminate it.
> 
> I disagree.

Indeed, plain yellow on a dark theme wouldn't look like a tooltip but a
big warning :P

>> We should also add a text highlight color, this constant does not
>> currently exist but should. Web+ uses orange, WTF is up with that?
> 
> Because no constant exists, I just picked one for Web+, and yeah it is
> kind of an ugly orange. It was meant to stand out because the previous
> color was deemed too hard to see. It probably would be good to add a
> constant for it, though it is also one of those things which needs to
> adapt based on the background color.
> 

Shrug, Firefox used violet, it's a progress :D

I thought we had one...

BTW, ZETA also had B_{PANEL|DOCUMENT}_LINK_COLOR, could be useful as
well (setting blue as text color would make links invisible).

While at it, one of my old svn working copies still had those around
that I wanted to add:
B_INPUT_METHOD_TRANSACTION_COLOR
B_INPUT_METHOD_CLAUSE_COLOR

They are currently hardcoded in BTextView IIRC, but applications
implementing input method things themselves would also need them anyway
(Terminal, XEmacs, ...).

And I miss B_MICHELANGELO_FAVORITE_COLOR btw :P

François.

Other related posts: