[haiku-commits] Re: haiku: hrev44422 - in src: libs/icon kits/tracker

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 28 Jul 2012 19:46:02 -0400

On Sat, Jul 28, 2012 at 5:24 PM, Ryan Leavengood <leavengood@xxxxxxxxx> wrote:
> On Saturday, July 28, 2012, wrote:
>>
>>
>> e51854a: Add 96x96 and 128x128 icon sizes to tracker including scaling of
>>
>> BeOS icons using scale3x and scale4x algorithms.
>
>
> This is great! But if those scaling functions are also used in Deskbar as I
> recall they are, maybe they could be put in the shared kit in a header. It
> would not change much as far as binary size, but in case of bug fixes or
> changes it means just one place to change. If you don't want to bother I can
> do it later.

Ryan,

The scaling methods are already in a shared location in:
src/libs/icon/IconUtils.cpp which is used by Deskbar as well as
Tracker and really any app that gets and scales icons from disk.
Remember that these methods work on bitmaps, not HVIF so only affect
legacy BeOS icons.

Screenshot of the methods in action: http://imagebin.org/222453

John Scipione

>
>
> --
> Regards,
> Ryan

Other related posts: