[haiku-commits] Re: haiku: hrev44217 - src/tools

  • From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 01 Jun 2012 11:12:15 -0500

On 01.06.2012 11:08, Jérôme Duval wrote:

Hi Alexander,

2012/6/1  <kallisti5@xxxxxxxxxxx>:

+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>


stdio comes before stdlib.


+               // Converting more than 32bit hexadecimal value?
+               if (szlen>8) return 2; // exit


return should go on the next line.


+               for (i = szlen - 1; i>=0 ;i--) {


space before and after the operator.


+                               if (*(xs+i)>=97) {


idem
Yeah, I wasn't being *too* careful on style because these aren't meant to go in the image.. they are tools for future developers who want to add new intel / amd cpuid's
Can fix though once I get this big cpuid change commited (see the haiku-development ML) 

 -- Alex

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 06-2012