[haiku-commits] Re: haiku: hrev44096 - src/apps/deskbar src/kits/interface headers/private/interface

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 03 May 2012 10:48:48 +0200

On 03.05.2012 07:20, jscipione@xxxxxxxxx wrote:
   * Rename DrawLabel() and SetDrawLabel() to HasLabel() and SetHasLabel()

That's a good name, indeed.

7f7f5ea: Refactor ToolTipManager a bit.

Looks good.

--- a/src/kits/interface/ToolTip.cpp
+++ b/src/kits/interface/ToolTip.cpp
@@ -207,6 +207,7 @@ BTextToolTip::SetText(const char* text)
                return;

        fTextView->SetText(text);
+       fTextView->InvalidateLayout();

While it's certainly okay to do it this way, I wonder if that shouldn't be the default behaviour for read-only text views. Any other opinions, especially of our layout gurus? :-)

Bye,
   Axel.

Other related posts: