[haiku-commits] Re: haiku: hrev44005 - src/apps/deskbar

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 13 Apr 2012 04:00:41 -0400

On Fri, Apr 13, 2012 at 3:23 AM, "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:
>> On Thu, Apr 12, 2012 at 4:15 AM, "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
>> wrote:
>> > On April 12, 2012 at 5:52 AM jscipione@xxxxxxxxx wrote:
>> >> +                        // couldn't find generic 3 boxes icon
>> >> +                        // fill with transparent
>> > Instead of this piece of code, why not delete the bitmap, and make the rest
>> > of
>> > the code deal with a NULL bitmap?
>> > That's at least a much cleaner approach, and will likely have the same end
>> > result.
>> Actually that is not a bad idea. But, because retrieving the 3 boxes
>> icon is almost guaranteed not to fail it isn't worth it to spend too
>> much effort on that case. As long as we do something better than
>> display a garbage bitmap.
>  Makes sense, however, maybe it could be put as an "easy" task into Trac, so
> that it could be tackled by someone interested to get in touch with Haiku.

I question how easy the task of allowing Deskbar to handle a NULL
BBitmap would be, but, I suppose by putting it on trac we could find
out.

John Scipione

Other related posts: