[haiku-commits] haiku: hrev43900 - src/add-ons/accelerants/radeon_hd
- From: kallisti5@xxxxxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 29 Mar 2012 19:55:48 +0200 (CEST)
hrev43900 adds 1 changeset to branch 'master'
old head: 7e9cb0275587be51109118f9ffcf6b6f385a070e
new head: 6aaadd60dd52c001bf402a6361ff11aa5834cb97
----------------------------------------------------------------------------
6aaadd6: radeon_hd: Fix bytes per row passed to app_server
* Video modes with widths that are not multiples of
32 were failing to set
* Should solve analog "skewed display"
* Add debugging on adjusted framebuffer pitch
* Thanks go out to AMD open source developers for
the help tracking this one down!
[ Alexander von Gluck IV <kallisti5@xxxxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev43900
Commit: 6aaadd60dd52c001bf402a6361ff11aa5834cb97
URL: http://cgit.haiku-os.org/haiku/commit/?id=6aaadd6
Author: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
Date: Thu Mar 29 11:59:49 2012 UTC
----------------------------------------------------------------------------
1 files changed, 9 insertions(+), 3 deletions(-)
src/add-ons/accelerants/radeon_hd/display.cpp | 12 +++++++++---
----------------------------------------------------------------------------
diff --git a/src/add-ons/accelerants/radeon_hd/display.cpp
b/src/add-ons/accelerants/radeon_hd/display.cpp
index 8e59b4b..6feaf01 100644
--- a/src/add-ons/accelerants/radeon_hd/display.cpp
+++ b/src/add-ons/accelerants/radeon_hd/display.cpp
@@ -627,8 +627,8 @@ display_crtc_fb_set(uint8 crtcID, display_mode* mode)
}
// Align our framebuffer width
- int widthAligned = mode->virtual_width;
- int pitchMask = 0;
+ uint32 widthAligned = mode->virtual_width;
+ uint32 pitchMask = 0;
switch (bytesPerPixel) {
case 1:
@@ -645,6 +645,12 @@ display_crtc_fb_set(uint8 crtcID, display_mode* mode)
widthAligned += pitchMask;
widthAligned &= ~pitchMask;
+ TRACE("%s: fb: %" B_PRIu32 "x%" B_PRIu32 " (%" B_PRIu32 " bpp)\n",
__func__,
+ mode->virtual_width, mode->virtual_height, bitsPerPixel);
+ TRACE("%s: fb pitch: %" B_PRIu32 " \n", __func__,
+ widthAligned * bytesPerPixel / 4);
+ TRACE("%s: fb width aligned: %" B_PRIu32 "\n", __func__,
+ widthAligned);
Write32(CRT, regs->grphSurfaceOffsetX, 0);
Write32(CRT, regs->grphSurfaceOffsetY, 0);
@@ -686,7 +692,7 @@ display_crtc_fb_set(uint8 crtcID, display_mode* mode)
}
// update shared info
- gInfo->shared_info->bytes_per_row = mode->virtual_width * bytesPerPixel;
+ gInfo->shared_info->bytes_per_row = widthAligned * bytesPerPixel;
gInfo->shared_info->current_mode = *mode;
gInfo->shared_info->bits_per_pixel = bitsPerPixel;
}
Other related posts:
- » [haiku-commits] haiku: hrev43900 - src/add-ons/accelerants/radeon_hd - kallisti5
