[haiku-commits] Re: haiku: hrev43839 - src/build/libroot
- From: John Scipione <jscipione@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 12 Mar 2012 16:28:01 -0400
On Mon, Mar 12, 2012 at 4:14 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>wrote:
> On 09.03.2012 22:41, jscipione@xxxxxxxxx wrote:
>
>> +++ b/src/build/libroot/fs_darwin.**cpp
>> @@ -19,12 +19,12 @@
>> #include<unistd.h>
>>
>>
>> -int get_path(int fd, const char* path, char** fullPath);
>> +int get_path(int fd, const char* path, char fullPath[]);
>>
>
> What is the prototype good for? And why is this function not static? If
> it's actually used anywhere else, it should not pollute the public
> namespace.
>
You are right, both get_path() and eaccess() are internal functions and
therefore should be static. Although it would be nice if eaccess() could be
included in Haiku despite the fact that it is not POSIX.
John Scipione
Other related posts:
