[haiku-commits] Re: haiku: hrev43777 - in src: kits/tracker apps apps/poorman . add-ons/kernel/file_systems/iso9660
- From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 3 Mar 2012 20:16:12 +0100
Hi Siarzhuk,
2012/3/3 Siarzhuk Zharski <zharik@xxxxxx>:
> Is this really intentional? I'm asking because you have precisely reverted
> your 6 years old commit (hrev17837
> http://cgit.haiku-os.org/haiku/commit/?id=a58450492adaa707bade05fc3be3758ae3dd6895).
> And this change break the current Keymap Switcher functionality and,
> probably it is not a single program that uses this way obtaining the
> Messenger using scripting.
This is an oversight from me. My intention was to handle the error
case properly instead of checking potential invalid values for "cur",
"prop".
>
> By the way, the check of "cur < 0" in the 'if' clause has no sence now
> because negative value of specifier index forces the GetCurrentSpecifier to
> return B_BAD_SCRIPT_SYNTAX error and break to the next handler immediately.
Right.
>
> In case the discussed modification is intentional - I think the reply with
> the real contents of "err" (B_BAD_SCRIPT_SYNTAX) should be send back instead
> of the generic B_NAME_NOT_FOUND.
I committed a change in hrev43815, please give it a shot.
Bye,
Jérôme
Other related posts:
